Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: (x/feegrant) add missing test scenarios #14018

Merged
merged 10 commits into from
Nov 30, 2022
Merged

chore: (x/feegrant) add missing test scenarios #14018

merged 10 commits into from
Nov 30, 2022

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Nov 25, 2022 •
edited
Loading

Description

ref: #13939, #13456

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title chore: add missing test scenarios chore: (x/feegrant) add missing test scenarios Nov 25, 2022
@atheeshp atheeshp marked this pull request as ready for review November 28, 2022 10:13
@atheeshp atheeshp requested a review from a team as a code owner November 28, 2022 10:13
facundomedica
facundomedica approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one little nit.

x/feegrant/keeper/msg_server_test.go Outdated Show resolved Hide resolved
likhita-809
likhita-809 approved these changes Nov 29, 2022
View reviewed changes
x/feegrant/keeper/msg_server_test.go Outdated Show resolved Hide resolved
@atheeshp atheeshp enabled auto-merge (squash) November 29, 2022 14:43
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Nov 29, 2022
@sonarqubecloud
Copy link

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 30, 2022
@atheeshp atheeshp merged commit 4a90621 into main Nov 30, 2022
@atheeshp atheeshp deleted the ap/feegrant-audit branch November 30, 2022 07:46
@mergify mergify bot mentioned this pull request Nov 30, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 30, 2022
@atheeshp @mergify
chore: (x/feegrant) add missing test scenarios (#14018)
a9fd3e7 
* add missing test scenarios

* review changes

(cherry picked from commit 4a90621)
tac0turtle pushed a commit that referenced this pull request Nov 30, 2022
@mergify
chore: (x/feegrant) add missing test scenarios (#14018) (#14085)
49e57b5
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@facundomedica facundomedica facundomedica approved these changes

Assignees

@amaury1093 amaury1093

@facundomedica facundomedica

Labels
A:automerge Automatically merge PR once all prerequisites pass. backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:x/feegrant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atheeshp @facundomedica @likhita-809 @amaury1093 @julienrbrt