Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove store kv dependency #14144

Merged
merged 22 commits into from
Dec 7, 2022
Merged

refactor: remove store kv dependency #14144

merged 22 commits into from
Dec 7, 2022

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Dec 4, 2022

Description

The kv.Pair(s) is needed for testing and to marshal the subspace key response. This is used for only the params module from my understanding. If we refactor the query interface (which I think we should) we should remove this dep.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Base automatically changed from marko/sdk_type_deps to main December 6, 2022 15:19
@tac0turtle tac0turtle marked this pull request as ready for review December 6, 2022 16:30
@tac0turtle tac0turtle requested a review from a team as a code owner December 6, 2022 16:30
@tac0turtle tac0turtle changed the title reactor: remove store kv dependency refactor: remove store kv dependency Dec 6, 2022
simapp/sim_test.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amaury1093 amaury1093 self-assigned this Dec 7, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@tac0turtle tac0turtle merged commit f3be418 into main Dec 7, 2022
@tac0turtle tac0turtle deleted the marko/kv_dep branch December 7, 2022 20:57
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants