-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(client): Remove usage of GetSignBytes from AuxTxBuilder #16025
Conversation
c2f6395
to
6631001
Compare
@@ -190,16 +212,43 @@ func (b *AuxTxBuilder) GetSignBytes() ([]byte, error) { | |||
} | |||
case signing.SignMode_SIGN_MODE_LEGACY_AMINO_JSON: | |||
{ | |||
signBz = legacytx.StdSignBytes( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key change in this PR, StdSignBytes calls legacyMsg.GetSignBytes, so we're now using the amino json signer in x/tx instead.
client/tx/aux_builder.go
Outdated
var err error | ||
b.auxSignerData.Mode = mode | ||
|
||
return nil | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like error is always gonna be nil no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, definitely. Thanks!
Description
Ref: #16024
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change