feat: make checksum optional in upgrade validation #16511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Cosmovisor
github-prbot
requested review from
a team,
facundomedica and
atheeshp
and removed request for
a team
tac0turtle
reviewed
Jun 13, 2023
| type ParseConfig struct { | ||
| // EnforceChecksum, if true, will cause all downloaded files to be checked against their checksums. | ||
| // When false, checksums are not enforced to be present in the url. | ||
| EnforceChecksum bool |
There was a problem hiding this comment.
if this is true and cosmovisor flag is false, which one takes priority?
There was a problem hiding this comment.
Basically, the software-upgrade CLI still requires a checksum for binary unless a flag is passed to disable it.
And cosmovisor by default do not require the software upgrade binary to have a checksum but an env variable can enforce it. When present checksums are always checked.
alexanderbez
approved these changes
Jun 13, 2023
|
@Mergifyio backport release/v0.50.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
(cherry picked from commit 62709ad) # Conflicts: # tools/cosmovisor/go.mod # tools/cosmovisor/go.sum
julienrbrt
added a commit
that referenced
this pull request
Jun 13, 2023
…16532) Co-authored-by: Julien Robert <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #10718, ref: #16131 (comment)
Unblocks: #16131
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change