feat(cosmovisor): add ability to run custom preupgrade script #16550
Conversation
github-prbot
requested review from
a team,
JeancarloBarrios and
julienrbrt
and removed request for
a team
chillyvee
changed the title
tools/cosmovisor/args.go
Outdated
There was a problem hiding this comment.
tests updated, waiting for results.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
julienrbrt
changed the title
|
Will take care of tests another day :) |
give us a ping whenever you have them 🙌 |
chillyvee
force-pushed
the
cv_cosmovisor_custom_preupgrade
branch
from
59367ed to
a6bc667
Compare
| } | ||
|
|
||
| // Run preupgradeFile | ||
| cmd := exec.Command(preupgradeFile, uInfo.Name, fmt.Sprintf("%d", uInfo.Height)) |
Check failure
Code scanning / gosec
Subprocess launched with variable
chillyvee
force-pushed
the
cv_cosmovisor_custom_preupgrade
branch
from
a6bc667 to
88ef8be
Compare
|
@facundomedica Tests added. Some "less related" github automated test fail, but the directly related tests pass.. If more adjustments necessary, please message back. |
tools/cosmovisor/process.go
Outdated
| return err | ||
| } | ||
|
|
||
| if uInfo.Name == "" { |
There was a problem hiding this comment.
nit: we could use the validate function on the plan
There was a problem hiding this comment.
changed code to use ValidateBasic
There was a problem hiding this comment.
should the test be removed completely since UpgradeBinary already checks upgradeInfo.ValidateFull()?
There was a problem hiding this comment.
Nice and thank you @chillyvee! LGTM to me mostly but there is an assertion that we need to make in the tests for cases where the preUpgrade file doesn't exist to ensure that the error is of type os.IsNotExist. Thank you.
|
@odeke-em Appreciate the comments! Running new commits through test. |
Description
Validators/Infrastructure providers need the ability to execute custom scripts for backup, alerting, and other functions prior to upgrade.
Set environment variable COSMOVISOR_CUSTOM_PREUPGRADE=preupgrade.sh to execute
.simapp/cosmovisor/preupgrade.shduring upgrade.Custom script is run with 2 arguments [ Upgrade Name, Upgrade Height ]
For example:
.simapp/cosmovisor/preupgrade.sh v2 2000for upgrade v2 at height 2000Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change