Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cosmovisor): enable logger configuration with env variable #16573

Merged
merged 1 commit into from
Jun 15, 2023
Merged

feat(cosmovisor): enable logger configuration with env variable #16573

merged 1 commit into from
Jun 15, 2023

Conversation

troian
Copy link
Contributor

@troian troian commented Jun 15, 2023 •
edited
Loading

add COSMOVISOR_COLOR_OUTPUT as an option to enable/disable colored logs add COSMOVISOR_TIMEFORMAT_LOGS as an option to configure/disable timestamp prefix in the logs

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@troian troian requested a review from a team as a code owner June 15, 2023 13:12
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Jun 15, 2023
@github-prbot github-prbot requested review from a team, JeancarloBarrios and likhita-809 and removed request for a team June 15, 2023 13:12
@troian troian force-pushed the cosmovisor-logs branch from cf8c76e to 5cc33cc Compare June 15, 2023 13:13
julienrbrt
julienrbrt reviewed Jun 15, 2023
View reviewed changes
tools/cosmovisor/cmd/cosmovisor/init.go Show resolved Hide resolved
tools/cosmovisor/cmd/cosmovisor/logger.go Outdated Show resolved Hide resolved
tools/cosmovisor/cmd/cosmovisor/run.go Outdated Show resolved Hide resolved
@troian troian force-pushed the cosmovisor-logs branch 3 times, most recently from 8f9a8b9 to 1b5a6c3 Compare June 15, 2023 15:13
@julienrbrt julienrbrt changed the title feat(tools/cosmovisor): extend cosmovisor variables feat(cosmovisor): enable logger configuration with env variable Jun 15, 2023
@troian troian force-pushed the cosmovisor-logs branch from 1b5a6c3 to d002cb9 Compare June 15, 2023 16:04
@troian
feat(tools/cosmovisor): extend cosmovisor variables
201f435 
add COSMOVISOR_COLOR_OUTPUT as an option to enable/disable colored logs
add COSMOVISOR_TIMEFORMAT_LOGS as an option to configure/disable
timestamp prefix in the logs

Signed-off-by: Artur Troian <[email protected]>
@troian troian force-pushed the cosmovisor-logs branch from d002cb9 to 201f435 Compare June 15, 2023 16:32
julienrbrt
julienrbrt approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! Nice addition.

@julienrbrt julienrbrt enabled auto-merge June 15, 2023 16:37
@julienrbrt julienrbrt added this pull request to the merge queue Jun 15, 2023
Merged via the queue into cosmos:main with commit a318ca9 Jun 15, 2023
@troian troian deleted the cosmovisor-logs branch June 15, 2023 16:53
@troian
Copy link
Contributor Author

troian commented Jun 15, 2023

@julienrbrt mind to cut a new release for cosmovisor?

@julienrbrt
Copy link
Member

julienrbrt commented Jun 15, 2023 •
edited
Loading

@julienrbrt mind to cut a new release for cosmovisor?

Soon™️, I'll gladly have the two PRs that are currently open merged first so we have a version with multiple new features.
You can keep track of the release #16131 where we'll be testing that there are no regression since 1.4.0 and we'll tag a 1.5.0.

If you are in a hurry you can always use a pseudo version (at your own risk).

@troian
Copy link
Contributor Author

troian commented Jun 15, 2023

ah, that will do, thanks

@coderabbitai coderabbitai bot mentioned this pull request Apr 23, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@likhita-809 likhita-809 Awaiting requested review from likhita-809

Assignees
No one assigned
Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@troian @julienrbrt