-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Issue Templates #1668
Add Issue Templates #1668
Conversation
## Proposed solution | ||
<!-- | ||
For Bugs: (if applicable) proposed steps for solution | ||
For Proposals: The Proposal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may confuse users if they think they have to propose a solution for bugs in order to file the issue. B/c of that, I think we should tag this as proposals only.
Also, should we add a note saying that proposals will be closed unless there is an actual concrete proposal? (I.e. for large feature requests, there has to be a description of what needs to be implemented, for small feature requests where its a (relatively) simple change this isn't needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to separate this out into multiple templates to distinguish bug fixes vs. feature requests - should alleviate some of the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to the proposal template Word of Caution: poorly thought-out proposals may be rejected without deliberation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Codecov Report
@@ Coverage Diff @@
## master #1668 +/- ##
=======================================
Coverage 62.84% 62.84%
=======================================
Files 124 124
Lines 6992 6992
=======================================
Hits 4394 4394
Misses 2346 2346
Partials 252 252 |
Two issue templates created:
Here is an idea of what it will look like https://help.github.com/articles/about-issue-and-pull-request-templates/