Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use appmodule.AppModule in new API #16754

Closed
wants to merge 4 commits into from
Closed

Conversation

julienrbrt
Copy link
Member

Description

Investigate how we can increase the usage of appmodule.AppModule instead of module.AppModule thorough the codebase.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the base branch from main to julien/integration-appmodule June 29, 2023 06:25
Copy link
Member Author

@julienrbrt julienrbrt Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes here will be reverted, but it easier to check where AppModuleBasic is really directly required.

Base automatically changed from julien/integration-appmodule to main June 29, 2023 08:18
@julienrbrt
Copy link
Member Author

From where this is going, I think this is too early. I'll go with the proposed solution from @tac0turtle, with a tweak of not adding an extension interface, but having the basic manager check the interface directly.

@julienrbrt julienrbrt closed this Jul 9, 2023
@julienrbrt julienrbrt deleted the julien/appmodule branch July 9, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant