Keep the spec consistent with LCD implementation #1733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## adrian/lcd_spec_final #1733 +/- ##
======================================================
Coverage 63.71% 63.71%
======================================================
Files 122 122
Lines 6774 6774
======================================================
Hits 4316 4316
Misses 2211 2211
Partials 247 247 |
melekes
reviewed
Aug 14, 2018
| Sample command: | ||
| | Parameter | Type | Default | Required | Description | | ||
| | ----------- | --------- | ----------------------- | -------- | ---------------------------------------------------- | | ||
| | home | string | "$HOME/.gaiacli" | false | directory for save checkpoints and validator sets | |
There was a problem hiding this comment.
save -> saved? or directory for storing ...
|
|
||
| * When the connected full node is trusted, then the proof is not necessary, so you can run Cosmos-LCD with trust-node option: | ||
| ``` | ||
| gaiacli advanced rest-server-swagger --chain-id {your chain id} --trust-node |
There was a problem hiding this comment.
note advanced prefix will soon be removed #2014
|
Bump. @adrianbrink is the branch this is targeted on still in use? If not, should this be retargeted? |
|
@cwgoes I think this is also part of #2177. Should we close this as well ? cc: @HaoyangLiu |
|
The PR is deprecated. The refered spec is outdated. I will create a new PR to keep its spec consistent with LCD implementation. Thanks for all your impressive comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we didn't take consideration of load balancing and swagger-ui. Now in LCD implementation, I add them, so some new options were added too. Please review this PR. Thanks