feat(accounts): implement account state isolation #17507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
August 21, 2023 14:45
# Conflicts: # x/accounts/go.mod # x/accounts/go.sum # x/accounts/internal/implementation/account_test.go # x/accounts/internal/implementation/api_builder.go # x/accounts/internal/implementation/implementation_test.go # x/accounts/internal/implementation/protoaccount.go
github-prbot
requested review from
a team,
tac0turtle and
julienrbrt
and removed request for
a team
|
@testinginprod your pull request is missing a changelog! |
testinginprod
commented
Aug 23, 2023
| // prefix. It is used to isolate storage reads and writes for an account. | ||
| // Implementation taken from cosmossdk.io/store/prefix, and adapted to | ||
| // the cosmossdk.io/core/store.KVStore interface. | ||
| package prefixstore |
There was a problem hiding this comment.
unfortunately we don't have a prefix store implementation which complies with core.store.KVStore ....
There was a problem hiding this comment.
for now this is probably fine with the ongoing work of storev2, in the future we can migrate to the store one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #17508
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change