feat(accounts): Add account Create,Execute,Query implementation #17515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2023 20:50
github-prbot
requested review from
a team,
facundomedica and
tac0turtle
and removed request for
a team
|
@testinginprod your pull request is missing a changelog! |
testinginprod
commented
Aug 23, 2023
| case oldVote.Option != v1beta1.OptionEmpty: //nolint:staticcheck // Depcrecated but required for migrations | ||
| newWVOs = v1.NewNonSplitVoteOption(v1.VoteOption(oldVote.Option)) //nolint:staticcheck // Depcrecated but required for migrations | ||
| case oldVote.Option != v1beta1.OptionEmpty: | ||
| newWVOs = v1.NewNonSplitVoteOption(v1.VoteOption(oldVote.Option)) |
There was a problem hiding this comment.
make lint fix's fault 😛
testinginprod
commented
Aug 23, 2023
x/accounts/module.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| // TODO: better address scheme, ref: https://github.com/cosmos/cosmos-sdk/issues/17516 |
There was a problem hiding this comment.
being kept track in an issue, so we don't forget, but shouldn't block the PR.
added 2 commits
August 23, 2023 20:57
tac0turtle
reviewed
Aug 24, 2023
tac0turtle
approved these changes
Aug 24, 2023
julienrbrt
reviewed
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #17514
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change