Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client/v2): remove trailing whitespace in golden files #17852

Merged

Conversation

odeke-em
Copy link
Collaborator

@odeke-em odeke-em commented Sep 25, 2023

Found while auditing v0.50.0-beta0 vs v0.50.0-rc0. In the future, one can verify absence by running

$ git grep '\s\+$' | cut -d":" -f1 | sort | uniq

Fixes #17851

…golden files

Found while auditing v0.50.0-beta0 vs v0.50.0-rc0. In the future, one
can verify absence by running

```shell
$ git grep '\s\+$' | cut -d":" -f1 | sort | uniq
```

Fixes #17851
@odeke-em odeke-em requested a review from a team as a code owner September 25, 2023 02:02
@github-prbot github-prbot requested review from a team, facundomedica and likhita-809 and removed request for a team September 25, 2023 02:03
@odeke-em odeke-em changed the title refactor: client/v2/autocli/testdata: remove trailing whitespace in .… refactor: client/v2/autocli/testdata: remove trailing whitespace in golden files Sep 25, 2023
@julienrbrt julienrbrt changed the title refactor: client/v2/autocli/testdata: remove trailing whitespace in golden files chore(client/v2): remove trailing whitespace in golden files Sep 25, 2023
@odeke-em odeke-em enabled auto-merge September 25, 2023 04:42
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Sep 25, 2023
@odeke-em odeke-em added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 35d93a9 Sep 25, 2023
@odeke-em odeke-em deleted the client-v2-autocli-remove-trailing-whitespace-in-golden-files branch September 25, 2023 06:19
mergify bot pushed a commit that referenced this pull request Sep 25, 2023
@faddat faddat mentioned this pull request Nov 8, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
3 participants