chore: Update RequestExtendVote #17993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
alexanderbez and
atheeshp
and removed request for
a team
facundomedica
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
LGTM, for some reason staking had some updates but it looks good. Thank you @sergio-mena for the heads up!
facundomedica
added
C:ABCI
backport/v0.50.x
julienrbrt
approved these changes
Oct 6, 2023
Let's be sure to re-run |
| @@ -395,8 +403,8 @@ message ExecTxResult { | |||
| bytes data = 2; | |||
| string log = 3; // nondeterministic | |||
| string info = 4; // nondeterministic | |||
| int64 gas_wanted = 5; | |||
| int64 gas_used = 6; | |||
| int64 gas_wanted = 5 [json_name = "gas_wanted"]; | |||
There was a problem hiding this comment.
This changed and break-check is pointing it out. It was done automatically after updating the Makefile
There was a problem hiding this comment.
We haven't released v0.50 anyway, so we don't mind.
mergify bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
(cherry picked from commit c325cbf) # Conflicts: # x/staking/types/staking.pb.go
julienrbrt
pushed a commit
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates RequestExtendVote per 0.38 as comet requested
Closes: #17992
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change