feat(store/v2): store v2 integration #18528
Conversation
|
Note Reviews PausedUse the following commands to manage reviews:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
|
@coderabbitai pause |
store/root/store.go
Outdated
|
|
||
| return &Store{ | ||
| logger: logger.With("module", "root_store"), | ||
| initialVersion: initVersion, |
There was a problem hiding this comment.
i dont think this is correct, height 1 is not always guranteed
There was a problem hiding this comment.
This is the default height. If a greater height is indicated via InitChain, SetInitialVersion is called.
| // is called. Note, events are automatically emitted on the parent context's | ||
| // EventManager when the caller executes the write. | ||
| func (c Context) CacheContext() (cc Context, writeCache func()) { |
There was a problem hiding this comment.
id leave this as is if we want to test on mainnets, we wont be able to change modules that depend on this
| @@ -0,0 +1,178 @@ | |||
| package store | |||
There was a problem hiding this comment.
could we spin the store pkg changes into its own pr, will help reduce the size of this pr
There was a problem hiding this comment.
Yes, of course.
github-actions
bot
added
C:x/staking
C:x/gov
C:x/distribution
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if app.rs == nil { | ||
| return errors.New("RootStore must not be nil") | ||
| } |
Check warning
Code scanning / CodeQL
Unreachable statement Warning
| if app.cms == nil { | ||
| return errors.New("commit multi-store must not be nil") | ||
| } |
Check warning
Code scanning / CodeQL
Unreachable statement Warning
|
Closing this PR as it's not the direction we want to take -- to breaking and tedious. The current proposal is to scrap integration into the now legacy BaseApp and instead focus on direct integration with server v2 in tandem. |
Description
Closes: #18466
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change