fix(x/auth/tx): JSON TX encoding/decoding (backport #20803)

[mergify]

Description

Fixes a regression in JSON transaction encoding/decoding introduced somewhere in recent x/tx refactors.

Previously decimal fields in proto specs were represented in JSON as human readable strings, e.g.

3.14159 -> "3.141590000000000000"

On main (today) they are represented by their backing word in the math package, e.g

3.14159 -> "3141590000000000000"

The latter is consistent with the at rest state representation, and proto wire format, but different from how JSON RPC represents decimals (the former) in the Amino ProtoJSON spec. See: #10863 (comment). As long as we're committing to AminoJSON at the JSON RPC boundary, we ought to represent JSON Txs with the same spec, Amino JSON.

The added test now fails without the patch to x/auth/tx in this PR like:

        	Messages:   	expected {"body":{"messages":[{"@type":"/testpb.TestMsg", "signers":["cosmos1dlgll8xq9e2yxd00qccw9mymqv45h8244jp4l8"], "decField":"3141590000000000000"}], "memo":"foomemo"}, "auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey", "key":"A87XkCofwGthnhovnbbKIx/F6ftaAm7tWDnykHLIWK3+"}, "mode_info":{"single":{"mode":"SIGN_MODE_LEGACY_AMINO_JSON"}}}], "fee":{"amount":[{"denom":"atom", "amount":"150"}], "gas_limit":"50000"}}, "signatures":["ZHVtbXlTaWc="]} to contain 3.141590000000000000

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:

• confirmed ! in the type prefix if API or client breaking change

• targeted the correct branch (see PR Targeting)

• provided a link to the relevant issue or specification

• reviewed "Files changed" and left comments if necessary

• included the necessary unit and integration tests

• added a changelog entry to CHANGELOG.md

• updated the relevant documentation or specification, including comments for documenting Go code

• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Added ValidatorInfo field to provide additional details for each validator.
  • Introduced a new field DecField in TestMsg for better message handling.
  • Added a new launch configuration for debugging the simapp application.

• Bug Fixes

  • Enhanced JSON decoding and marshaling in transaction encoding and decoding functions.

• Tests

  • Updated test cases to include the new DecField for comprehensive validation.

• Chores

  • Updated imports and internal methods to align with new protobuf and JSON handling libraries.

---

This is an automatic backport of pull request #20803 done by [Mergify](https://mergify.com).

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

@mergify[bot] your pull request is missing a changelog!