Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/cosmos/cosmos-sdk from 0.50.8 to 0.50.9 in /tools/hubl #21207

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 8, 2024

Bumps github.com/cosmos/cosmos-sdk from 0.50.8 to 0.50.9.

Release notes

Sourced from github.com/cosmos/cosmos-sdk's releases.

v0.50.9

Cosmos SDK v0.50.9 Release Notes

💬 Release Discussion

🚀 Highlights

For this month patch release of the v0.50.x line, some bugs were fixed.

Notably, we fixed the following:

  • PreBlock events (mainly x/upgrade) are now emitted
  • Improve compatibility of depinject v1.0.0 with app.yaml / app.json

📝 Changelog

Check out the changelog for an exhaustive list of changes, or compare changes from the last release.

Refer to the upgrading guide when migrating from v0.47.x to v0.50.1. Note, that the next SDK release, v0.52, will not include x/params migration, when migrating from < v0.47, v0.50.x or v0.47.x, is a mandatory migration.

Changelog

Sourced from github.com/cosmos/cosmos-sdk's changelog.

v0.50.9 - 2024-08-07

Bug Fixes

  • (baseapp) #21159 Return PreBlocker events in FinalizeBlockResponse.
  • #20939 Fix collection reverse iterator to include pagination.key in the result.
  • (client/grpc) #20969 Fix node.NewQueryServer method not setting cfg.
  • (testutil/integration) #21006 Fix NewIntegrationApp method not writing default genesis to state.
  • (runtime) #21080 Fix app.yaml / app.json incompatibility with depinject v1.0.0.
Commits
  • 8bfcf55 ci: attempt to fix goreleaser (backport #21194) (#21196)
  • 16d3025 chore: prepare v0.50.9 (#21163)
  • 3f6796f fix(baseapp): return events from preblocker in FinalizeBlockResponse (backpor...
  • 3fc8074 build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (#21170)
  • a565daa chore: bring in v0.13.x x/tx in release/v0.50.x (#21158)
  • 31ef899 docs: Fix cli usage examples (backport #21150) (#21154)
  • ffd5696 fix(simapp): concurrent map writes when calling GetSigners (backport #21073) ...
  • 91d412c feat: check latest block if no arg in q block and q block-results (backpo...
  • e135030 fix(runtime): remove appv1alpha1.Config from runtime (backport #21042) (#21...
  • 0702719 feat: use depinject v1.0.0 (#21000)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • New Features
    • Updated dependencies to enhance functionality and security, improving overall performance and stability.
  • Chores
    • Removed the indirect dependency on github.com/libp2p/go-buffer-pool, streamlining the dependency management.

Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.50.8 to 0.50.9.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.50.9/CHANGELOG.md)
- [Commits](v0.50.8...v0.50.9)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner August 8, 2024 02:07
@dependabot dependabot bot added A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file labels Aug 8, 2024
Copy link
Contributor

coderabbitai bot commented Aug 8, 2024

Walkthrough

Walkthrough

The recent updates to the go.mod file enhance several dependencies within the project, reflecting minor version upgrades that likely improve functionality and security. Notably, the removal of the indirect dependency on github.com/libp2p/go-buffer-pool suggests a shift in dependency management. These changes aim to streamline the project's dependency tree, potentially leading to improved performance and stability.

Changes

Files Change Summary
tools/hubl/go.mod Upgraded dependencies: cosmossdk.io/core to v0.11.1, cosmos-sdk to v0.50.9, cosmossdk.io/x/tx to v0.13.4, and cometbft to v0.38.10. Removed github.com/libp2p/go-buffer-pool (v0.1.0).

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (2)
tools/hubl/go.mod (2)

8-8: Update Required for cosmossdk.io/core v0.11.1 Compatibility

The update to cosmossdk.io/core v0.11.1 involves moving RegisterInterfaces and RegisterImplementations to a new interface, cosmossdk.io/core/registry.InterfaceRegistrar. This change affects several parts of the codebase where these methods are used.

  • Update all occurrences of RegisterInterfaces and RegisterImplementations to use the new InterfaceRegistrar interface.
  • Ensure that all modules implementing HasRegisterInterfaces are updated to accept a cosmossdk.io/core/registry.InterfaceRegistrar instead of the previous InterfaceRegistry.

These changes are necessary to maintain compatibility with the updated dependency.

  • Affected Files:
    • x/upgrade/types/codec.go
    • x/staking/types/codec.go
    • x/slashing/types/codec.go
    • x/gov/types/v1/codec.go
    • x/mint/types/codec.go
    • x/nft/codec.go
    • ... (and many more)

Please review and update the affected parts of the codebase accordingly.

Analysis chain

Update cosmossdk.io/core to v0.11.1.

The update from v0.11.0 to v0.11.1 likely includes bug fixes and improvements. Ensure that the changes in this version are compatible with your project.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility of `cosmossdk.io/core` v0.11.1 with the project.

# Test: Check for any breaking changes or deprecations in the changelog.
rg --type markdown 'cosmossdk.io/core' CHANGELOG.md

Length of output: 407


Script:

#!/bin/bash
# Search for usage of `types/module.HasRegisterInterfaces` in the codebase.
rg 'types/module.HasRegisterInterfaces'

# Search for usage of `RegisterInterfaces` and `RegisterImplementations` in the codebase.
rg 'RegisterInterfaces'
rg 'RegisterImplementations'

Length of output: 28533


10-10: Compatibility Issues Detected with github.com/cosmos/cosmos-sdk v0.50.9

The following potential compatibility issues were identified in the codebase after updating to github.com/cosmos/cosmos-sdk v0.50.9:

  • x/genutil Usage: The x/genutil package is used extensively throughout the codebase. Ensure that any changes or deprecations in this package are addressed.
  • MsgSimulatorFn Changes: The MsgSimulatorFn has been updated. Ensure that the new function signature and usage are compatible with the current implementation.
  • GetSignBytes Implementations: There are multiple occurrences of GetSignBytes. Verify that these implementations align with the updated SDK requirements.
  • x/auth Module Changes: The x/auth module has undergone significant changes. Review its usage in the codebase to ensure compatibility with the latest version.

These areas need to be reviewed and potentially updated to ensure compatibility with the new SDK version.

  • Files to Review:
    • x/genutil related files
    • types/simulation/types.go and related files for MsgSimulatorFn
    • x/tx/signing and other related files for GetSignBytes
    • All files importing or using x/auth

Please address these issues to ensure smooth integration with the latest SDK version.

Analysis chain

Update github.com/cosmos/cosmos-sdk to v0.50.9.

The update includes bug fixes and improvements. Verify that the new version does not introduce breaking changes for your project.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility of `github.com/cosmos/cosmos-sdk` v0.50.9 with the project.

# Test: Check for any breaking changes or deprecations in the changelog.
rg --type markdown 'github.com/cosmos/cosmos-sdk' CHANGELOG.md

Length of output: 265408


Script:

#!/bin/bash
# Search for usage of deprecated or changed functions, methods, or modules as per the changelog.

# Check for usage of removed `Any` type from `codec/types`.
rg 'codec/types.Any' --type go

# Check for usage of `servertypes.ModuleInitFlags` which has been removed.
rg 'servertypes.ModuleInitFlags' --type go

# Check for usage of deprecated `IntProto` and `DecProto`.
rg 'IntProto|DecProto' --type go

# Check for usage of `WrapServiceResult` function which has been removed.
rg 'WrapServiceResult' --type go

# Check for usage of `x/genutil` related changes.
rg 'x/genutil' --type go

# Check for usage of `MsgSimulatorFn` which has changed.
rg 'MsgSimulatorFn' --type go

# Check for usage of `server.AddCommands` which has changed.
rg 'server.AddCommands' --type go

# Check for usage of `GetSignBytes` implementations which have been removed.
rg 'GetSignBytes' --type go

# Check for usage of `x/auth` module changes.
rg 'x/auth' --type go

Length of output: 63624

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4dc9469 and 11e44a9.

Files ignored due to path filters (1)
  • tools/hubl/go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • tools/hubl/go.mod (4 hunks)
Additional comments not posted (3)
tools/hubl/go.mod (3)

42-42: Update github.com/cometbft/cometbft to v0.38.10.

The update from v0.38.9 to v0.38.10 likely includes minor changes or bug fixes. Verify that these changes are compatible with your project.

Verification successful

Compatibility Confirmed for github.com/cometbft/cometbft v0.38.10

The update to version v0.38.10 includes bug fixes and performance improvements without any breaking changes or deprecations. It should be compatible with your project.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility of `github.com/cometbft/cometbft` v0.38.10 with the project.

# Test: Check for any breaking changes or deprecations in the changelog.
rg --type markdown 'github.com/cometbft/cometbft' CHANGELOG.md

Length of output: 1206


Script:

#!/bin/bash
# Description: Fetch and examine the changelog for CometBFT v0.38.10 to verify compatibility.

# Fetch the changelog for CometBFT v0.38.10
curl -s https://raw.githubusercontent.com/cometbft/cometbft/v0.38.10/CHANGELOG.md

Length of output: 38903


24-24: Update cosmossdk.io/x/tx to v0.13.4.

This update likely includes minor improvements or bug fixes. Ensure there are no breaking changes affecting your project.


11-11: Removal of github.com/libp2p/go-buffer-pool.

The removal of this indirect dependency suggests it is no longer needed. Verify that its removal does not affect any functionality in the project.

@github-actions github-actions bot added the C:Hubl Tool: Hubl label Aug 8, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 11e44a9 and a66d598.

Files ignored due to path filters (1)
  • tools/hubl/go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • tools/hubl/go.mod (4 hunks)
Files skipped from review as they are similar to previous changes (1)
  • tools/hubl/go.mod

@tac0turtle tac0turtle added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 90741c3 Aug 8, 2024
72 of 74 checks passed
@tac0turtle tac0turtle deleted the dependabot/go_modules/tools/hubl/github.com/cosmos/cosmos-sdk-0.50.9 branch August 8, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Hubl Tool: Hubl dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants