-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump github.com/cosmos/cosmos-sdk from 0.50.8 to 0.50.9 in /tools/hubl #21207
build(deps): Bump github.com/cosmos/cosmos-sdk from 0.50.8 to 0.50.9 in /tools/hubl #21207
Conversation
Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.50.8 to 0.50.9. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.50.9/CHANGELOG.md) - [Commits](v0.50.8...v0.50.9) --- updated-dependencies: - dependency-name: github.com/cosmos/cosmos-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
WalkthroughWalkthroughThe recent updates to the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
tools/hubl/go.mod (2)
8-8
: Update Required forcosmossdk.io/core
v0.11.1 CompatibilityThe update to
cosmossdk.io/core
v0.11.1 involves movingRegisterInterfaces
andRegisterImplementations
to a new interface,cosmossdk.io/core/registry.InterfaceRegistrar
. This change affects several parts of the codebase where these methods are used.
- Update all occurrences of
RegisterInterfaces
andRegisterImplementations
to use the newInterfaceRegistrar
interface.- Ensure that all modules implementing
HasRegisterInterfaces
are updated to accept acosmossdk.io/core/registry.InterfaceRegistrar
instead of the previousInterfaceRegistry
.These changes are necessary to maintain compatibility with the updated dependency.
- Affected Files:
x/upgrade/types/codec.go
x/staking/types/codec.go
x/slashing/types/codec.go
x/gov/types/v1/codec.go
x/mint/types/codec.go
x/nft/codec.go
- ... (and many more)
Please review and update the affected parts of the codebase accordingly.
Analysis chain
Update
cosmossdk.io/core
to v0.11.1.The update from
v0.11.0
tov0.11.1
likely includes bug fixes and improvements. Ensure that the changes in this version are compatible with your project.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `cosmossdk.io/core` v0.11.1 with the project. # Test: Check for any breaking changes or deprecations in the changelog. rg --type markdown 'cosmossdk.io/core' CHANGELOG.mdLength of output: 407
Script:
#!/bin/bash # Search for usage of `types/module.HasRegisterInterfaces` in the codebase. rg 'types/module.HasRegisterInterfaces' # Search for usage of `RegisterInterfaces` and `RegisterImplementations` in the codebase. rg 'RegisterInterfaces' rg 'RegisterImplementations'Length of output: 28533
10-10
: Compatibility Issues Detected withjackfan.us.kg/cosmos/cosmos-sdk
v0.50.9The following potential compatibility issues were identified in the codebase after updating to
github.com/cosmos/cosmos-sdk
v0.50.9:
x/genutil
Usage: Thex/genutil
package is used extensively throughout the codebase. Ensure that any changes or deprecations in this package are addressed.MsgSimulatorFn
Changes: TheMsgSimulatorFn
has been updated. Ensure that the new function signature and usage are compatible with the current implementation.GetSignBytes
Implementations: There are multiple occurrences ofGetSignBytes
. Verify that these implementations align with the updated SDK requirements.x/auth
Module Changes: Thex/auth
module has undergone significant changes. Review its usage in the codebase to ensure compatibility with the latest version.These areas need to be reviewed and potentially updated to ensure compatibility with the new SDK version.
- Files to Review:
x/genutil
related filestypes/simulation/types.go
and related files forMsgSimulatorFn
x/tx/signing
and other related files forGetSignBytes
- All files importing or using
x/auth
Please address these issues to ensure smooth integration with the latest SDK version.
Analysis chain
Update
github.com/cosmos/cosmos-sdk
to v0.50.9.The update includes bug fixes and improvements. Verify that the new version does not introduce breaking changes for your project.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `github.com/cosmos/cosmos-sdk` v0.50.9 with the project. # Test: Check for any breaking changes or deprecations in the changelog. rg --type markdown 'github.com/cosmos/cosmos-sdk' CHANGELOG.mdLength of output: 265408
Script:
#!/bin/bash # Search for usage of deprecated or changed functions, methods, or modules as per the changelog. # Check for usage of removed `Any` type from `codec/types`. rg 'codec/types.Any' --type go # Check for usage of `servertypes.ModuleInitFlags` which has been removed. rg 'servertypes.ModuleInitFlags' --type go # Check for usage of deprecated `IntProto` and `DecProto`. rg 'IntProto|DecProto' --type go # Check for usage of `WrapServiceResult` function which has been removed. rg 'WrapServiceResult' --type go # Check for usage of `x/genutil` related changes. rg 'x/genutil' --type go # Check for usage of `MsgSimulatorFn` which has changed. rg 'MsgSimulatorFn' --type go # Check for usage of `server.AddCommands` which has changed. rg 'server.AddCommands' --type go # Check for usage of `GetSignBytes` implementations which have been removed. rg 'GetSignBytes' --type go # Check for usage of `x/auth` module changes. rg 'x/auth' --type goLength of output: 63624
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (1)
tools/hubl/go.sum
is excluded by!**/*.sum
Files selected for processing (1)
- tools/hubl/go.mod (4 hunks)
Additional comments not posted (3)
tools/hubl/go.mod (3)
42-42
: Updatejackfan.us.kg/cometbft/cometbft
to v0.38.10.The update from
v0.38.9
tov0.38.10
likely includes minor changes or bug fixes. Verify that these changes are compatible with your project.Verification successful
Compatibility Confirmed for
github.com/cometbft/cometbft
v0.38.10The update to version v0.38.10 includes bug fixes and performance improvements without any breaking changes or deprecations. It should be compatible with your project.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility of `github.com/cometbft/cometbft` v0.38.10 with the project. # Test: Check for any breaking changes or deprecations in the changelog. rg --type markdown 'github.com/cometbft/cometbft' CHANGELOG.mdLength of output: 1206
Script:
#!/bin/bash # Description: Fetch and examine the changelog for CometBFT v0.38.10 to verify compatibility. # Fetch the changelog for CometBFT v0.38.10 curl -s https://raw.githubusercontent.com/cometbft/cometbft/v0.38.10/CHANGELOG.mdLength of output: 38903
24-24
: Updatecosmossdk.io/x/tx
to v0.13.4.This update likely includes minor improvements or bug fixes. Ensure there are no breaking changes affecting your project.
11-11
: Removal ofjackfan.us.kg/libp2p/go-buffer-pool
.The removal of this indirect dependency suggests it is no longer needed. Verify that its removal does not affect any functionality in the project.
…cosmos/cosmos-sdk-0.50.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files ignored due to path filters (1)
tools/hubl/go.sum
is excluded by!**/*.sum
Files selected for processing (1)
- tools/hubl/go.mod (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- tools/hubl/go.mod
Bumps github.com/cosmos/cosmos-sdk from 0.50.8 to 0.50.9.
Release notes
Sourced from github.com/cosmos/cosmos-sdk's releases.
Changelog
Sourced from github.com/cosmos/cosmos-sdk's changelog.
Commits
8bfcf55
ci: attempt to fix goreleaser (backport #21194) (#21196)16d3025
chore: prepare v0.50.9 (#21163)3f6796f
fix(baseapp): return events from preblocker in FinalizeBlockResponse (backpor...3fc8074
build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (#21170)a565daa
chore: bring in v0.13.x x/tx in release/v0.50.x (#21158)31ef899
docs: Fix cli usage examples (backport #21150) (#21154)ffd5696
fix(simapp): concurrent map writes when calling GetSigners (backport #21073) ...91d412c
feat: check latest block if no arg inq block
andq block-results
(backpo...e135030
fix(runtime): removeappv1alpha1.Config
from runtime (backport #21042) (#21...0702719
feat: use depinject v1.0.0 (#21000)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit
github.com/libp2p/go-buffer-pool
, streamlining the dependency management.