Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Remove gocyclo #2228

Merged
merged 2 commits into from
Sep 4, 2018
Merged

tools: Remove gocyclo #2228

merged 2 commits into from
Sep 4, 2018

Conversation

ValarDragon
Copy link
Contributor

We can investigate re-introducing our own fork #postlaunch.
Closes #2211

I chose to leave this commented in the makefile, as a reminder that were considering re-including postlaunch. If we ever decide to remove it permanently, lets delete it then. (Though I guess it is easy enough to add back, I don't feel a need to bikeshed this so if anyones opposed, I'll delete it now)

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

We can investigate re-introducing our own fork #postlaunch.
Closes #2211
@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #2228 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2228   +/-   ##
========================================
  Coverage    64.23%   64.23%           
========================================
  Files          140      140           
  Lines         8575     8575           
========================================
  Hits          5508     5508           
  Misses        2690     2690           
  Partials       377      377

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

You wrote remove golint in the changelog but I think you meant remove gocyclo, updated the entry

@cwgoes cwgoes merged commit d736204 into develop Sep 4, 2018
@cwgoes cwgoes deleted the dev/remove_golint branch September 4, 2018 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants