Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseapp: Remove baseapp.SetTxDecoder() #2230

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Conversation

ValarDragon
Copy link
Contributor

Closes #1441

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Updated relevant documentation (docs/) - nothing showed up in documentation with ag settxdecoder.

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #2230 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2230      +/-   ##
===========================================
+ Coverage     64.2%   64.23%   +0.02%     
===========================================
  Files          140      140              
  Lines         8579     8575       -4     
===========================================
  Hits          5508     5508              
+ Misses        2694     2690       -4     
  Partials       377      377

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

The best kind of PR!

@cwgoes cwgoes merged commit d1e8eda into develop Sep 4, 2018
@cwgoes cwgoes deleted the dev/remove_settxdecoder branch September 4, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants