R4R: add various gov cmds to docs and other fixes #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedekunze
added
T:Docs
fedekunze
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## docs-overhaul #2631 +/- ##
================================================
Coverage ? 58.77%
================================================
Files ? 152
Lines ? 9433
Branches ? 0
================================================
Hits ? 5544
Misses ? 3519
Partials ? 370 |
added 2 commits
October 30, 2018 09:51
fedekunze
changed the title
zramsay
reviewed
Oct 30, 2018
zramsay
reviewed
Oct 30, 2018
docs/sdk/cosmos-sdk-cli.md
Outdated
| @@ -1,19 +1,18 @@ | |||
| # cosmos-sdk-cli | |||
| Create a new blockchain project based on cosmos-sdk with a single command. | |||
| # cosmos-sdk-cli | |||
There was a problem hiding this comment.
these are the titles that show up in the sidebar, would be good to pretty-fy it
There was a problem hiding this comment.
how would you rename it ?
There was a problem hiding this comment.
I'm good with the current naming. Having a section named after a specific tool is OK right?
docs/lite/specification.md
Outdated
| @@ -92,12 +92,12 @@ the postition of the target key in the whole key set of this IAVL tree. As shown | |||
| out the left key and the right key. If we can demonstrate that both left key and right key | |||
| definitely exist, and they are adjacent nodes. Thus the target key definitely doesn't exist. | |||
|
|
|||
|  | |||
|  | |||
added 2 commits
October 30, 2018 15:39
alexanderbez
reviewed
Nov 1, 2018
alexanderbez
previously requested changes
Nov 1, 2018
Co-Authored-By: fedekunze <[email protected]>
…osmos-sdk into fedekunze/docs-cli-lite merge develop
gamarin2
reviewed
Nov 1, 2018
Co-Authored-By: fedekunze <[email protected]>
added 2 commits
November 1, 2018 22:47
…edekunze/docs-cli-lite merge develop
…osmos-sdk into fedekunze/docs-cli-lite Merge
|
@cwgoes @zramsay @gamarin2 @jackzampolin anything left for this PR ? I addressed all the comments above |
|
@zramsay do we want to get these fixes merged before we move the docs??? |
|
doesn't really matter, either way it's a hassle for someone |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: