Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]: Add keys/accounts section to localnet docs #2702

Merged
merged 8 commits into from
Nov 7, 2018

Conversation

alexanderbez
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added the T:Docs Changes and features related to documentation. label Nov 6, 2018
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

docs/getting-started/networks.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

❗ No coverage uploaded for pull request base (docs-overhaul@b51aaaa). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             docs-overhaul    #2702   +/-   ##
================================================
  Coverage                 ?   58.01%           
================================================
  Files                    ?      153           
  Lines                    ?     9511           
  Branches                 ?        0           
================================================
  Hits                     ?     5518           
  Misses                   ?     3632           
  Partials                 ?      361

@zramsay
Copy link
Contributor

zramsay commented Nov 6, 2018

can you changed base to docs-overhaul since the location of this file has changed

@alexanderbez alexanderbez changed the base branch from develop to docs-overhaul November 6, 2018 15:36
@alexanderbez
Copy link
Contributor Author

Done, I'll need to address the conflict.

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍒 🍎 🍉

docs/getting-started/networks.md Outdated Show resolved Hide resolved
@alexanderbez
Copy link
Contributor Author

alexanderbez commented Nov 7, 2018

@zramsay @greg-szabo -- address the PR comments and changed the base. Should be good to merge. Although install_examples is failing on docs_overhaul.

@alexanderbez alexanderbez changed the title Add keys/accounts section to localnet docs [R4R]: Add keys/accounts section to localnet docs Nov 7, 2018
@zramsay
Copy link
Contributor

zramsay commented Nov 7, 2018

ah, we moved the examples to docs/examples, i'll fix that

@zramsay zramsay merged commit c664917 into docs-overhaul Nov 7, 2018
@zramsay zramsay deleted the bez/localnet-docs-update branch November 7, 2018 15:15
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants