-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R4R]: Add keys/accounts section to localnet docs #2702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Codecov Report
@@ Coverage Diff @@
## docs-overhaul #2702 +/- ##
================================================
Coverage ? 58.01%
================================================
Files ? 153
Lines ? 9511
Branches ? 0
================================================
Hits ? 5518
Misses ? 3632
Partials ? 361 |
can you changed base to |
Done, I'll need to address the conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍒 🍎 🍉
@zramsay @greg-szabo -- address the PR comments and changed the base. Should be good to merge. Although |
ah, we moved the examples to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: