R4R: Fix governance simulation, more import/export work #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
@@ Coverage Diff @@
## develop #2748 +/- ##
===========================================
- Coverage 56.67% 56.64% -0.04%
===========================================
Files 156 156
Lines 9783 9800 +17
===========================================
+ Hits 5545 5551 +6
- Misses 3861 3872 +11
Partials 377 377 |
27 tasks
|
Just FYI the simulation script is failing for most seeds. |
cwgoes
changed the title
alexanderbez
approved these changes
Nov 13, 2018
| @go test ./cmd/gaia/app -run TestGaiaImportExport -SimulationEnabled=true -SimulationNumBlocks=50 -SimulationBlockSize=200 -SimulationCommit=true -SimulationSeed=13 -v -timeout 24h | ||
| @go test ./cmd/gaia/app -run TestGaiaImportExport -SimulationEnabled=true -SimulationNumBlocks=50 -SimulationBlockSize=200 -SimulationCommit=true -SimulationSeed=414 -v -timeout 24h | ||
| @go test ./cmd/gaia/app -run TestGaiaImportExport -SimulationEnabled=true -SimulationNumBlocks=50 -SimulationBlockSize=200 -SimulationCommit=true -SimulationSeed=4142 -v -timeout 24h | ||
| @bash scripts/import-export-sim.sh 50 |
| echo "Running multi-seed import-export simulation with seeds ${seeds[@]}" | ||
| echo "Running $blocks blocks per seed" | ||
| echo "Edit scripts/import-export-sim.sh to add new seeds. Keeping parameters in the file makes failures easy to reproduce." | ||
| echo "This script will kill all sub-simulations on SIGINT/SIGTERM (i.e. Ctrl-C)." |
There was a problem hiding this comment.
🙌ran into this a few times lately
|
LGTM! Looks good to me and was able to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2733
Addresses remaining comments from #2690
Standard checklist:
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: