-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ubuntu install script #2803
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2803 +/- ##
=======================================
Coverage 56.6% 56.6%
=======================================
Files 156 156
Lines 9836 9836
=======================================
Hits 5568 5568
Misses 3888 3888
Partials 380 380 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, also needs a PENDING.md
entry. Haven't tested the script yet, will test after revisions.
This script is part of updating the docs, I really don't think it should have a changelog entry. |
just tested on fresh DO instance (w/ latest commit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Ubuntu 18.04 (Docker).
Targeted PR against correct branch (see CONTRIBUTING.md)
Updated relevant documentation (
docs/
) - this is the docsAdded entries in
PENDING.md
with issue # - updating docs doesn't require thisrereviewed
Files changed
in the github PR explorerFor Admin Use: