Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubuntu install script #2803

Merged
merged 4 commits into from
Nov 15, 2018
Merged

Update ubuntu install script #2803

merged 4 commits into from
Nov 15, 2018

Conversation

ValarDragon
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Updated relevant documentation (docs/) - this is the docs

  • Added entries in PENDING.md with issue # - updating docs doesn't require this

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2803 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #2803   +/-   ##
=======================================
  Coverage     56.6%   56.6%           
=======================================
  Files          156     156           
  Lines         9836    9836           
=======================================
  Hits          5568    5568           
  Misses        3888    3888           
  Partials       380     380

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, also needs a PENDING.md entry. Haven't tested the script yet, will test after revisions.

@ValarDragon
Copy link
Contributor Author

ValarDragon commented Nov 14, 2018

This script is part of updating the docs, I really don't think it should have a changelog entry.

@zramsay
Copy link
Contributor

zramsay commented Nov 14, 2018

just tested on fresh DO instance (w/ latest commit)

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ubuntu 18.04 (Docker).

@cwgoes cwgoes merged commit 7f68cee into develop Nov 15, 2018
@cwgoes cwgoes deleted the dev/update_ubuntu_install branch November 15, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants