Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Remove unused bank.MsgIssue (and prevent possible panic) #2855

Merged
merged 2 commits into from
Nov 19, 2018
Merged

R4R: Remove unused bank.MsgIssue (and prevent possible panic) #2855

merged 2 commits into from
Nov 19, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Nov 19, 2018 •
edited
Loading

Closes #2854

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added T:Bug ready-for-review T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). labels Nov 19, 2018
@cwgoes cwgoes changed the title Remove unused bank.MsgIssue (and prevent possible panic) R4R: Remove unused bank.MsgIssue (and prevent possible panic) Nov 19, 2018
@jackzampolin jackzampolin mentioned this pull request Nov 19, 2018
Closed
27 tasks
jackzampolin
jackzampolin approved these changes Nov 19, 2018
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pulled down and run tests. Also read through the code. This PR removes a bunch of unused code. Gets a 👍 from me!

alexanderbez
alexanderbez approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ☕️ (only CI failure is due to an already known and unrelated regression)

@jackzampolin jackzampolin merged commit fd968f7 into develop Nov 19, 2018
@jackzampolin jackzampolin deleted the cwgoes/remove-unused-bank-msg-issue branch November 19, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@sunnya97 sunnya97 Awaiting requested review from sunnya97

Assignees
No one assigned
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwgoes @alexanderbez @jackzampolin