Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Sunny/tombstone spec #3103

Merged
merged 27 commits into from
Jan 29, 2019
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1a26f32
in progress:
sunnya97 Dec 6, 2018
346bf9c
in progress
sunnya97 Dec 13, 2018
3fe1688
in progress
sunnya97 Dec 13, 2018
3bb6de9
in progress
sunnya97 Dec 17, 2018
96c074c
asdf
sunnya97 Dec 17, 2018
5b9aa01
Update docs/spec/slashing/tombstone.md
alexanderbez Dec 19, 2018
04c2e6e
fixed incorrect note
sunnya97 Dec 19, 2018
4faf5fb
comments
sunnya97 Jan 1, 2019
3864df3
asdf
sunnya97 Jan 2, 2019
55a5fbf
Rigel typos
sunnya97 Jan 6, 2019
1ecbca1
Update docs/spec/slashing/tombstone.md
alexanderbez Jan 6, 2019
368cfcb
Update docs/spec/slashing/tombstone.md
alexanderbez Jan 6, 2019
8a4499f
Update docs/spec/slashing/tombstone.md
alexanderbez Jan 6, 2019
d695766
tombstone is just jailed with infinite jail
sunnya97 Jan 6, 2019
c0a79c7
tombstone is just jailed with infinite jail
sunnya97 Jan 6, 2019
822c7ee
merge conflicts
sunnya97 Jan 6, 2019
e52f32a
Merge branch 'develop' into sunny/tombstone-spec
sunnya97 Jan 22, 2019
8a29ae2
in progress
sunnya97 Jan 22, 2019
25afcae
addressed comments
sunnya97 Jan 24, 2019
aa699dc
Merge branch 'develop' into sunny/tombstone-spec
sunnya97 Jan 24, 2019
a9f2c67
fix misspelling
sunnya97 Jan 28, 2019
ef1428b
Merge branch 'develop' into sunny/tombstone-spec
sunnya97 Jan 28, 2019
331d84a
removed devtools-stamp
sunnya97 Jan 28, 2019
fba6660
Apply @cwgoes suggestions from code review
cwgoes Jan 29, 2019
4fa183d
removed future improvements
sunnya97 Jan 29, 2019
153190c
Apply @cwgoes suggestions from code review
cwgoes Jan 29, 2019
78424da
typo fixes and minor markdown restructure
Jan 29, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed future improvements
  • Loading branch information
sunnya97 committed Jan 29, 2019
commit 4fa183db96f6498542cdfadddd514f6b5902a695
2 changes: 0 additions & 2 deletions docs/spec/slashing/tombstone.md
Original file line number Diff line number Diff line change
@@ -36,8 +36,6 @@ Currently, in the jail period implementation, once a validator unjails, all of t

Implementing the tombstone system and getting rid of the slashing period tracking will make the `slashing` module way simpler, especially because we can remove all of the hooks defined in the `slashing` module consumed by the `staking` module (the `slashing` module still consumes hooks defined in `staking`).

## Further improvements / Related proposals:

### Single slashing amount
sunnya97 marked this conversation as resolved.
Show resolved Hide resolved

Another optimization that can be made is that if we assume that all ABCI faults for Tendermint consensus are slashed at the same level, we don't have to keep track of "max slash". Once an ABCI fault happens, we don't have to worry about comparing potential future ones to find the max.