R4R: enrich version command's output

[alessio]

Closes: #1894

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added entries in PENDING.md with issue #
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[cwgoes]

Quick early review; needs PENDING.md too.

[codecov]

Codecov Report

Merging #3343 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #3343   +/-   ##
=======================================
  Coverage     54.9%   54.9%           
=======================================
  Files          132     132           
  Lines         9680    9680           
=======================================
  Hits          5315    5315           
  Misses        4028    4028           
  Partials       337     337

[alexanderbez]

Running this for the first time for me yields:

cat: vendor-deps: No such file or directory
cat: vendor-deps: No such file or directory
cat: vendor-deps: No such file or directory
cat: vendor-deps: No such file or directory
cat: vendor-deps: No such file or directory
go install -tags "netgo ledger" -ldflags "-X github.com/cosmos/cosmos-sdk/version.Version=0.29.1-98-gf4c84046 -X github.com/cosmos/cosmos-sdk/version.Commit=f4c8404607c94eb0feb6e182bce31b54f827d241 -X github.com/cosmos/cosmos-sdk/version.VendorDirHash=" ./cmd/gaia/cmd/gaiad
...

Then, gaiad version yields:

cosmos-sdk 0.29.1-98-gf4c84046
latest commit: f4c8404607c94eb0feb6e182bce31b54f827d241
vendor/ directory's hash:
go version go1.11 darwin/amd64

[alexanderbez]

Do we need this duplicate entry? I think the CLI will suffice.

[alexanderbez]

Suggested change

	fmt.Printf("go version %s %s/%s\n",
	fmt.Printf("go version: %s %s/%s\n",

[jackzampolin]

Maybe we also make the option to output this as JSON?

[greg-szabo]

Renaming is fine with caveats, the reading of file content need to be changed.

Addressed.

[alessio]

$(file <) requires Make 4.2. I think I found a portable way of achieving the same result

…

On Tue, Jan 22, 2019 at 5:14 PM Greg Szabo ***@***.***> wrote: ***@***.**** requested changes on this pull request. Renaming is fine with caveats, the reading of file content need to be changed. ------------------------------ In Makefile <#3343 (comment)>: > @@ -131,10 +131,11 @@ devtools-stamp: tools go get github.com/tendermint/lint/golint touch $@ -get_vendor_deps: tools +vendor-deps: tools What Mircea and Jack said. Not crazy about current naming conventions but they seeped into everything. (Just look at some of the faucet code or the telegram bot.) I don't mind accepting this new naming as long as CircleCI is also updated *and* if we (eventually) come up with how this should look like so it's not nilly-willy. :) The cat vendor-deps part however won't work on Windows. Please use $(file < vendor-deps) instead. (And test it, this is off the top of my head.) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3343 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN_7NvPx4E3l6ntalUTjKwUGExz4fbUks5vF0b4gaJpZM4aL7P0> .

-- Alessio Treglia | [email protected] 0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A

[alexanderbez]

Merge conflict relics

[alessio]

I removed the cruft leftover. This should not affect the merge.