Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README[spanish].md && vesting[Spanish].md #3772

Closed
wants to merge 2 commits into from
Closed

Create README[spanish].md && vesting[Spanish].md #3772

wants to merge 2 commits into from

Conversation

wimel
Copy link
Contributor

@wimel wimel commented Mar 1, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

wimel added 2 commits December 9, 2018 21:21
Some parts are too difficult to translate, but I have tried to do my best
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #3772 into develop will increase coverage by 2.32%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3772      +/-   ##
===========================================
+ Coverage     61.4%   63.72%   +2.32%     
===========================================
  Files          189      109      -80     
  Lines        14094     6034    -8060     
===========================================
- Hits          8654     3845    -4809     
+ Misses        4885     1970    -2915     
+ Partials       555      219     -336

@jackzampolin
Copy link
Member

¡Hola @wimel, gracias por tu contribución!

Can you please create these files in the /docs/translations/sp/ folder with a folder structure mirroring that of the repository? So for the two files above that would be:

./README[spanish].md -> ./docs/translations/sp/README.md
./docs/spec/auth/vesting[spanish].md -> ./docs/translations/sp/spec/auth/vesting.md

@wimel
Copy link
Contributor Author

wimel commented Mar 1, 2019

yes sure, I can do it!!
I'm going to close this pr and make a new one with a few more things, sorry for the inconveniences and thanks

@jackzampolin
Copy link
Member

@wimel not at all! Thank you very much for the translations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants