Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Simulator: Set Quorum field in appStateRandomizedFn #3796

Merged
merged 1 commit into from
Mar 4, 2019
Merged

R4R: Simulator: Set Quorum field in appStateRandomizedFn #3796

merged 1 commit into from
Mar 4, 2019

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Mar 4, 2019

This avoids a nil pointer dereference, e.g., when the simulator displays log messages. This change
is intended to be consistent with:

TallyParams: TallyParams{
Quorum: sdk.NewDecWithPrec(334, 3),
Threshold: sdk.NewDecWithPrec(5, 1),
Veto: sdk.NewDecWithPrec(334, 3),


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #3796 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3796   +/-   ##
========================================
  Coverage    61.02%   61.02%           
========================================
  Files          191      191           
  Lines        14174    14174           
========================================
  Hits          8649     8649           
  Misses        4971     4971           
  Partials       554      554

1 similar comment
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #3796 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3796   +/-   ##
========================================
  Coverage    61.02%   61.02%           
========================================
  Files          191      191           
  Lines        14174    14174           
========================================
  Hits          8649     8649           
  Misses        4971     4971           
  Partials       554      554

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks

@cwgoes cwgoes merged commit e1ad738 into cosmos:develop Mar 4, 2019
@smoelius smoelius deleted the simulator-gov-genesis branch March 4, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants