-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WithdrawValidatorCommission #3836
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #3836 +/- ##
===========================================
- Coverage 60.92% 60.92% -0.01%
===========================================
Files 192 192
Lines 14323 14328 +5
===========================================
+ Hits 8727 8729 +2
- Misses 5027 5030 +3
Partials 569 569 |
alexanderbez
added
the
T: State Machine Breaking
State machine breaking changes (impacts consensus).
label
Mar 8, 2019
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
March 8, 2019 18:37
cwgoes
approved these changes
Mar 11, 2019
rigelrozanski
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, given comments are addressed
This was referenced Mar 11, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C:x/distribution
distribution module related
C:x/staking
T: State Machine Breaking
State machine breaking changes (impacts consensus).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
WithdrawValidatorCommission
to set the validator's remaining commission correctly (i.e. taking care of the case when the remainder is zero).ref: #3830
closes: #3837
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: