Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP client generalization #4296

Closed

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented May 8, 2019

closes #1124
closes #2955
closes #4299

followup to module genesis generalization, this work needs to be done in a separate PR

to accomplish the client generalization which is in theory pretty simple there is an enormous amount of restructuring required due to lots of early design choices which are now leading to lots of circular dependencies.

The current state of the PR actually has most of the core updates, but the restructuring is going to be quite large

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@rigelrozanski rigelrozanski changed the base branch from rigel/genesis-generalization3 to master May 29, 2019 20:55
@rigelrozanski rigelrozanski changed the base branch from master to rigel/genesis-generalization3 May 29, 2019 21:01
@rigelrozanski
Copy link
Contributor Author

replaced by #4451

@odeke-em odeke-em deleted the rigel/client-generalization branch December 10, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant