Migrate Validators v0.36 #4770
Merged
Migrate Validators v0.36 #4770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4770 +/- ##
=======================================
Coverage 53.88% 53.88%
=======================================
Files 270 270
Lines 17230 17230
=======================================
Hits 9285 9285
Misses 7261 7261
Partials 684 684 |
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
| Rate sdk.Dec `json:"rate"` | ||
| MaxRate sdk.Dec `json:"max_rate"` | ||
| MaxChangeRate sdk.Dec `json:"max_change_rate"` | ||
| Rate sdk.Dec `json:"rate"` |
There was a problem hiding this comment.
This is what the struct actually looks like 👌
jackzampolin
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
ACK cause I know @alexanderbez tested this on mainnet w/ an export.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]Re-reviewed
Files changedin the github PR explorerFor Admin Use: