-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tools dependency #4801
Update tools dependency #4801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Technically runsim is not a dependency of the project, but it is easier to have it in go.mod
rather than having to ensure it never gets committed by anyone by mistake.
Codecov Report
@@ Coverage Diff @@
## master #4801 +/- ##
==========================================
- Coverage 50.5% 50.49% -0.02%
==========================================
Files 288 288
Lines 18518 18518
==========================================
- Hits 9353 9351 -2
- Misses 8480 8482 +2
Partials 685 685 |
agree with @colin-axner . since these files will change after Otherwise, we will have commits that either add or remove meaningless dependencies to SDK Thoughts? @mircea-c |
255c26f
to
eb6b527
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Commit that referred to tools dependency does not exist in git history because of force push. Update go.mod to refer to latest commit
docs/
)clog add [section] [-t <tag>] [-m <msg>]
Files changed
in the github PR explorerFor Admin Use: