-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup node_info Endpoint #4837
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
WIP
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
T: API Breaking
Breaking changes that impact APIs and the SDK only (not state machine).
labels
Aug 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #4837 +/- ##
==========================================
- Coverage 54.18% 54.14% -0.05%
==========================================
Files 269 269
Lines 17191 17209 +18
==========================================
+ Hits 9315 9317 +2
- Misses 7186 7202 +16
Partials 690 690 |
alexanderbez
requested review from
alessio,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
August 2, 2019 14:21
fedekunze
reviewed
Aug 2, 2019
fedekunze
reviewed
Aug 2, 2019
Co-Authored-By: Federico Kunze <[email protected]>
Co-Authored-By: Federico Kunze <[email protected]>
fedekunze
approved these changes
Aug 2, 2019
alexanderbez
added a commit
that referenced
this pull request
Aug 2, 2019
This was referenced Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T: API Breaking
Breaking changes that impact APIs and the SDK only (not state machine).
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_info
endpoint to also include application version infonew output:
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [-t <tag>] [-m <msg>]
Re-reviewed
Files changed
in the github PR explorerFor Admin Use: