Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Height Query Fixes #4905

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Aug 14, 2019

closes #4903


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #4905 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #4905      +/-   ##
==========================================
+ Coverage   53.63%   53.64%   +<.01%     
==========================================
  Files         270      270              
  Lines       16982    16988       +6     
==========================================
+ Hits         9109     9113       +4     
- Misses       7184     7185       +1     
- Partials      689      690       +1

@alexanderbez alexanderbez merged commit 9adb398 into master Aug 14, 2019
@alexanderbez alexanderbez deleted the bez/4903-height-proof-query-fixes branch August 14, 2019 16:45
alexanderbez added a commit that referenced this pull request Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expect bank/balances use latest height when height param not specified
2 participants