Swagger Auto Gen - Gov Updates #5088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackzampolin
requested review from
alessio,
alexanderbez,
fedekunze and
rigelrozanski
as code owners
golangcibot
reviewed
Sep 21, 2019
fedekunze
suggested changes
Sep 25, 2019
alexanderbez
suggested changes
Sep 30, 2019
There was a problem hiding this comment.
bump @jackzampolin. All new types should probably be type grouped with a // nolint: deadcode.
16 tasks
Co-Authored-By: Federico Kunze <[email protected]>
Codecov Report
@@ Coverage Diff @@
## bez/2179-auto-swagger #5088 +/- ##
=========================================================
+ Coverage 55.03% 55.04% +0.01%
=========================================================
Files 291 291
Lines 17839 17839
=========================================================
+ Hits 9818 9820 +2
+ Misses 7314 7312 -2
Partials 707 707 |
golangcibot
reviewed
Sep 30, 2019
golangcibot
reviewed
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds better return types to the already completed gov work