Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Genesis File Timestamp #5148

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Use Genesis File Timestamp #5148

merged 1 commit into from
Oct 7, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Oct 7, 2019

When a genesis file is provided to simulation, use the file's genesis time unless a custom genesis timestamp is provided by flag.

ref: #4750


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #5148 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5148      +/-   ##
==========================================
- Coverage   54.98%   54.95%   -0.03%     
==========================================
  Files         297      297              
  Lines       18225    18231       +6     
==========================================
- Hits        10021    10019       -2     
- Misses       7466     7474       +8     
  Partials      738      738

@alexanderbez alexanderbez merged commit fd76e62 into master Oct 7, 2019
@alexanderbez alexanderbez deleted the bez/use-genesis-time-sim branch October 7, 2019 17:17
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants