Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup genesis state validation + Genutil #5499

Merged
merged 3 commits into from
Jan 9, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 9, 2020

Closes: #5086

  • Ensure gentxs default genesis state is not nil
  • Cleanup and add context to ValidateGenesis methods.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #5499 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5499      +/-   ##
==========================================
+ Coverage   54.52%   54.53%   +0.01%     
==========================================
  Files         313      313              
  Lines       18877    18877              
==========================================
+ Hits        10293    10295       +2     
+ Misses       7800     7798       -2     
  Partials      784      784
Impacted Files Coverage Δ
x/mock/app.go 65.54% <0%> (+1.35%) ⬆️

@alexanderbez alexanderbez added the C:genesis relating to chain genesis label Jan 9, 2020
@alexanderbez alexanderbez merged commit 3df3887 into master Jan 9, 2020
@alexanderbez alexanderbez deleted the bez/5086-fix-bad-genesis-validation branch January 9, 2020 20:14
@alexanderbez alexanderbez mentioned this pull request Mar 10, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:genesis relating to chain genesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad genesis validation error
2 participants