Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADR 004 Implementation II (Unit Tests & Misc.) #5580

Merged
merged 34 commits into from
Jan 30, 2020
Merged

ADR 004 Implementation II (Unit Tests & Misc.) #5580

merged 34 commits into from
Jan 30, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 28, 2020 •
edited
Loading

Part II PR of #5572. This PR covers updating and fixing unit tests along with any misc. changes.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez mentioned this pull request Jan 28, 2020
Merged
13 tasks
@alexanderbez alexanderbez marked this pull request as ready for review January 28, 2020 22:14
@alexanderbez alexanderbez added R4R and removed WIP labels Jan 28, 2020
golangcibot
golangcibot reviewed Jan 28, 2020
View reviewed changes
x/gov/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/gov/keeper/keeper_test.go Outdated Show resolved Hide resolved
x/gov/keeper/proposal_test.go Outdated Show resolved Hide resolved
golangcibot
golangcibot reviewed Jan 28, 2020
View reviewed changes
x/gov/keeper/proposal_test.go Outdated Show resolved Hide resolved
x/gov/keeper/proposal_test.go Outdated Show resolved Hide resolved
fedekunze
fedekunze approved these changes Jan 29, 2020
View reviewed changes
x/bank/genesis.go Outdated Show resolved Hide resolved
x/bank/internal/keeper/keeper_test.go Outdated Show resolved Hide resolved
jackzampolin
jackzampolin approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@alexanderbez alexanderbez merged commit 4290946 into bez/5519-adr-004-bank-balances Jan 30, 2020
@alexanderbez alexanderbez deleted the bez/5519-adr-004-bank-balances-ii branch January 30, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@fedekunze fedekunze fedekunze approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@alessio alessio Awaiting requested review from alessio

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@sunnya97 sunnya97 Awaiting requested review from sunnya97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexanderbez @jackzampolin @fedekunze @golangcibot