Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: sentence about gas is not correct currently #5625

Merged
merged 2 commits into from
Feb 7, 2020
Merged

docs: sentence about gas is not correct currently #5625

merged 2 commits into from
Feb 7, 2020

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Feb 7, 2020 •
edited
Loading

Signed-off-by: Marko Baricevic [email protected]

Closes: #5623

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@tac0turtle
docs: sentence about gas is not correct currently
e13b85a 
[skip ci]

Signed-off-by: Marko Baricevic <[email protected]>
@tac0turtle tac0turtle force-pushed the marko/remove_incorrectDocs branch from fce1ea3 to e13b85a Compare February 7, 2020 14:47
@tac0turtle tac0turtle mentioned this pull request Feb 7, 2020
Closed
@alexanderbez alexanderbez added T:Docs Changes and features related to documentation. R4R labels Feb 7, 2020
alexanderbez
alexanderbez approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 605afd4 into master Feb 7, 2020
@alexanderbez alexanderbez deleted the marko/remove_incorrectDocs branch February 7, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excess gas consumed by transactions
2 participants
@tac0turtle @alexanderbez