Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak mergify config #5734

Merged
merged 3 commits into from
Mar 2, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Mar 1, 2020

Set minimum approvers number to be strictly greater than 1.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Set minimum approvers number to be strictly greater than 1.
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 1, 2020
@tac0turtle
Copy link
Member

This pull request must be merged manually because it modifies Mergify configuration

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is for auto-merge only, I suppose this is OK.

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #5734 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5734   +/-   ##
=======================================
  Coverage   36.22%   36.22%           
=======================================
  Files         335      335           
  Lines       32722    32722           
=======================================
  Hits        11855    11855           
  Misses      19641    19641           
  Partials     1226     1226           

@alexanderbez alexanderbez merged commit f403cda into master Mar 2, 2020
@alexanderbez alexanderbez deleted the alessio/mergify-approvers-no-greater-than-1 branch March 2, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants