-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible Port Binding for Transfer Module #6011
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6011 +/- ##
==========================================
- Coverage 55.32% 55.29% -0.03%
==========================================
Files 428 429 +1
Lines 25548 25562 +14
==========================================
+ Hits 14134 14135 +1
- Misses 10441 10454 +13
Partials 973 973 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AdityaSripal !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK modulo @fedekunze comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Description
Allows transfer module to bind to
portID =/= "transfer"
by specifying the portID in the genesis state.Removes check in channel callbacks
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)