Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Tendermint v0.33.4 #6055

Merged
merged 8 commits into from
Apr 22, 2020
Merged

Bump Tendermint v0.33.4 #6055

merged 8 commits into from
Apr 22, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 22, 2020 •
edited
Loading

We have to manually bump Tendermint to 0.33.4 because APIs & packages were broken :(

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez self-assigned this Apr 22, 2020
@alexanderbez alexanderbez marked this pull request as ready for review April 22, 2020 17:58
@alexanderbez alexanderbez requested a review from nylira as a code owner April 22, 2020 17:58
@alexanderbez alexanderbez added R4R dependencies Pull requests that update a dependency file and removed WIP labels Apr 22, 2020
@codecov
Copy link

codecov bot commented Apr 22, 2020 •
edited
Loading

Codecov Report

Merging #6055 into master will increase coverage by 0.00%.
The diff coverage is 36.84%.

@@           Coverage Diff           @@
##           master    #6055   +/-   ##
=======================================
  Coverage   54.64%   54.64%           
=======================================
  Files         425      425           
  Lines       25815    25822    +7     
=======================================
+ Hits        14106    14111    +5     
- Misses      10735    10737    +2     
  Partials      974      974

cwgoes
cwgoes approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 🎉

@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 22, 2020
@mergify mergify bot merged commit 72a2dae into master Apr 22, 2020
@mergify mergify bot deleted the bez/bump-tm-v0.33.4 branch April 22, 2020 19:21
@Itchibon777 Itchibon777 mentioned this pull request Dec 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters left review comments

@jackzampolin jackzampolin jackzampolin left review comments

@fedekunze fedekunze fedekunze approved these changes

@cwgoes cwgoes cwgoes approved these changes

@alessio alessio Awaiting requested review from alessio

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@nylira nylira Awaiting requested review from nylira

Assignees

@alexanderbez alexanderbez

Labels
A:automerge Automatically merge PR once all prerequisites pass. dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexanderbez @jackzampolin @cwgoes @cmwaters @fedekunze