move packet executed call to ibc handler #6312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6312 +/- ##
==========================================
- Coverage 55.61% 55.61% -0.01%
==========================================
Files 448 448
Lines 26941 26947 +6
==========================================
+ Hits 14984 14987 +3
- Misses 10883 10886 +3
Partials 1074 1074 |
colin-axner
commented
Jun 2, 2020
| @@ -61,7 +61,7 @@ type IBCModule interface { | |||
| OnRecvPacket( | |||
| ctx sdk.Context, | |||
| packet channeltypes.Packet, | |||
| ) (*sdk.Result, error) | |||
| ) (*sdk.Result, []byte, error) | |||
There was a problem hiding this comment.
I decided to modify the callback interface because
- it is more clear to the application developer the contract required to fulfill this function securely
- using
sdk.Result.Datawould be messy because you would need to require some specified format for the ack such as being prefixed by some string ie[]byte("acknowledgement")+ack.GetBytes()
There was a problem hiding this comment.
Agreed, I think this is cleaner for the time being.
colin-axner
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
colin-axner
changed the title
fedekunze
approved these changes
Jun 4, 2020
Can we just also check (but not increment) in |
cwgoes
approved these changes
Jun 4, 2020
| @@ -61,7 +61,7 @@ type IBCModule interface { | |||
| OnRecvPacket( | |||
| ctx sdk.Context, | |||
| packet channeltypes.Packet, | |||
| ) (*sdk.Result, error) | |||
| ) (*sdk.Result, []byte, error) | |||
There was a problem hiding this comment.
Agreed, I think this is cleaner for the time being.
fedekunze
added
the
A:automerge
This was referenced Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am leaving the check that the msg recv is in the correct order in
PacketExecutedrather than doing this check inRecvPacketbecause after this check is made, the nextRecvSeq is incremented, so it is cleaner to leave it in the...Executedfunc. The downside of this is application logic will be executed (but not persisted) even if the packet is to fail because it was received out of order. Any opinions on this?closes: #6301
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer