-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gRPC queries into BaseApp #6335
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6335 +/- ##
==========================================
+ Coverage 55.61% 55.65% +0.03%
==========================================
Files 448 448
Lines 26947 26961 +14
==========================================
+ Hits 14987 15005 +18
+ Misses 10886 10879 -7
- Partials 1074 1077 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aaronc, just a minor nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Alexander Bezobchuk <[email protected]>
This pull request introduces 7 alerts when merging abaf39a into b1f483f - view on LGTM.com new alerts:
|
…aronc/5921-grpc-baseapp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK :)
ref: #5921
This PR:
GRPCRouter
toGRPCQueryRouter
which makes more sense because it is just for queries (other non-query gRPC services would be handled separately)GRPCQueryRouter
toBaseApp
and integrates it into the ABCI query handlerFor contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer