Add gRPC server & reflection #6463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6463 +/- ##
==========================================
- Coverage 61.54% 61.48% -0.07%
==========================================
Files 508 510 +2
Lines 31523 31597 +74
==========================================
+ Hits 19402 19428 +26
- Misses 10611 10656 +45
- Partials 1510 1513 +3 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
4 tasks
…ronc/5921-grpc-proxy
…ronc/5921-grpc-proxy
aaronc
commented
Jul 24, 2020
fedekunze
reviewed
Jul 24, 2020
alexanderbez
added
A:automerge
aaronc
commented
Jul 27, 2020
anilcse
approved these changes
Jul 27, 2020
| @@ -186,8 +186,8 @@ func (app *BaseApp) MountKVStores(keys map[string]*sdk.KVStoreKey) { | |||
| } | |||
| } | |||
|
|
|||
| // MountStores mounts all IAVL or DB stores to the provided keys in the BaseApp | |||
| // multistore. | |||
| // MountTransientStores mounts all IAVL or DB stores to the provided keys in | |||
There was a problem hiding this comment.
Suggested change
| // MountTransientStores mounts all IAVL or DB stores to the provided keys in | |
| // MountTransientStores mounts all the transient stores from the MultiStore. |
| } | ||
|
|
||
| // Create the sdk.Context. Passing false as 2nd arg, as we can't | ||
| // actually support proofs with gRPC right now. |
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Add gRPC proxy * Make GRPC disabled by default * WIP on integration tests * WIP on integration tests * Start setting up in process tests * Start setting up in process tests * Make it compile * Add start server to network util * Add Println * Use go routine * Fix scopelint * Move to proxy_test * Add response type cache * Remove proxy * Tweaks * Use channel to handle error * Use error chan * Update server/start.go Co-authored-by: Federico Kunze <[email protected]> * Use %w * Add sdk.Context * Add comments * Fix lint * Add header and tests * Address comments * Factorize some code * Fix lint * Add height and prove in req metadata * Add reflection test * Fix lint * Put grpc test in server/grpc * Update baseapp/grpcserver.go * Update baseapp/grpcserver.go * Remove proof header Co-authored-by: Amaury Martiny <[email protected]> Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: Alexander Bezobchuk <[email protected]> Co-authored-by: SaReN <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5921
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer