-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/mint: gRPC query service #6535
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6535 +/- ##
==========================================
+ Coverage 57.72% 57.74% +0.02%
==========================================
Files 494 495 +1
Lines 29644 29656 +12
==========================================
+ Hits 17111 17125 +14
+ Misses 11301 11300 -1
+ Partials 1232 1231 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It'd be nice if we could use the existing testing suite for the setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍, just some docs update
…dk into atheesh/5921-grpc-x-mint
Description
ref: #5921
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer