Update x/{mint,slashing,evidence} cli to use gRPC query client #6704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6704 +/- ##
==========================================
- Coverage 60.31% 60.27% -0.04%
==========================================
Files 513 513
Lines 31491 31508 +17
==========================================
Hits 18993 18993
- Misses 11048 11068 +20
+ Partials 1450 1447 -3 |
amaury1093
reviewed
Jul 15, 2020
amaury1093
changed the title
|
@atheeshp since you also did evidence in this PR, i renamed the title 👍 |
This was referenced Jul 15, 2020
9 tasks
…21-grpc-cli-mint-slashing
…21-grpc-cli-mint-slashing
…21-grpc-cli-mint-slashing
…21-grpc-cli-mint-slashing
…os/cosmos-sdk into atheesh/5921-grpc-cli-mint-slashing
…21-grpc-cli-mint-slashing
…os/cosmos-sdk into atheesh/5921-grpc-cli-mint-slashing
atheeshp
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
atheeshp
requested review from
amaury1093,
sahith-narahari,
anilcse,
blushi and
clevinson
and removed request for
clevinson
alexanderbez
approved these changes
Jul 18, 2020
…21-grpc-cli-mint-slashing
fedekunze
approved these changes
Jul 19, 2020
chengwenxi
pushed a commit
to irisnet/cosmos-sdk
that referenced
this pull request
Jul 22, 2020
…s#6704) * changes cli to use gRPC in mint, slashing * added command for signing infos * gRPC query client migration of evidence * review changes * added unpack any * fixed build error * fixed failing tests issue * added read flags * added pagination flags * updated docs * fixed tests issue * failing tests * fixed tests * review changes * review changes Co-authored-by: Anil Kumar Kammari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #5921
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes