Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag & toml config for gRPC server #6933

Merged
merged 10 commits into from
Aug 5, 2020
Merged

Add flag & toml config for gRPC server #6933

merged 10 commits into from
Aug 5, 2020

Conversation

amaury1093
Copy link
Contributor

Description

Add flag & toml config for gRPC server

ref: #5921 (comment)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@amaury1093 amaury1093 changed the title Enable gRPC by default Add flag & toml config for gRPC server Aug 4, 2020
@aaronc aaronc mentioned this pull request Aug 5, 2020
43 tasks
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #6933 into master will increase coverage by 5.42%.
The diff coverage is 56.41%.

@@            Coverage Diff             @@
##           master    #6933      +/-   ##
==========================================
+ Coverage   55.60%   61.02%   +5.42%     
==========================================
  Files         457      379      -78     
  Lines       27440    24640    -2800     
==========================================
- Hits        15257    15037     -220     
+ Misses      11083     8430    -2653     
- Partials     1100     1173      +73     

@amaury1093 amaury1093 marked this pull request as ready for review August 5, 2020 12:50
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to expose the new port to the nodes on docker. The following files need to be updated

  • docker-compose.yml
  • Dockerfile

@amaury1093
Copy link
Contributor Author

let me fix the failing test first before merging

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 5, 2020
@mergify mergify bot merged commit d2661a4 into master Aug 5, 2020
@mergify mergify bot deleted the am-grpc-config branch August 5, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants