-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag & toml config for gRPC server #6933
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
changed the title
Enable gRPC by default
Add flag & toml config for gRPC server
Aug 4, 2020
aaronc
reviewed
Aug 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #6933 +/- ##
==========================================
+ Coverage 55.60% 61.02% +5.42%
==========================================
Files 457 379 -78
Lines 27440 24640 -2800
==========================================
- Hits 15257 15037 -220
+ Misses 11083 8430 -2653
- Partials 1100 1173 +73 |
amaury1093
requested review from
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
August 5, 2020 12:50
fedekunze
suggested changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to expose the new port to the nodes on docker. The following files need to be updated
- docker-compose.yml
- Dockerfile
fedekunze
approved these changes
Aug 5, 2020
tac0turtle
approved these changes
Aug 5, 2020
let me fix the failing test first before merging |
amaury1093
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add flag & toml config for gRPC server
ref: #5921 (comment)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes