Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add staking CLI tests #7111

Merged
merged 16 commits into from
Sep 11, 2020
Merged

Add staking CLI tests #7111

merged 16 commits into from
Sep 11, 2020

Conversation

murthyvitwit
Copy link
Contributor

@murthyvitwit murthyvitwit commented Aug 19, 2020

Description

ref: #7067


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #7111 into master will increase coverage by 0.58%.
The diff coverage is 49.89%.

@@            Coverage Diff             @@
##           master    #7111      +/-   ##
==========================================
+ Coverage   55.60%   56.18%   +0.58%     
==========================================
  Files         457      584     +127     
  Lines       27440    40513   +13073     
==========================================
+ Hits        15257    22762    +7505     
- Misses      11083    15834    +4751     
- Partials     1100     1917     +817     

@murthyvitwit murthyvitwit marked this pull request as draft August 19, 2020 20:00
@atheeshp atheeshp marked this pull request as ready for review September 7, 2020 16:10
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 7, 2020
@atheeshp atheeshp requested a review from anilcse September 10, 2020 14:37
@mergify mergify bot merged commit 1c31725 into cosmos:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants