Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing cli tests in x/staking #7158

Merged
merged 11 commits into from
Sep 17, 2020
Merged

Conversation

atheeshp
Copy link
Contributor

ref: #7067

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #7158 into master will increase coverage by 1.31%.
The diff coverage is 51.33%.

@@            Coverage Diff             @@
##           master    #7158      +/-   ##
==========================================
+ Coverage   55.60%   56.91%   +1.31%     
==========================================
  Files         457      585     +128     
  Lines       27440    40685   +13245     
==========================================
+ Hits        15257    23155    +7898     
- Misses      11083    15582    +4499     
- Partials     1100     1948     +848     

Add build-simd-linux to make's command line.
@alessio alessio requested a review from PaddyMc September 17, 2020 10:47
@robert-zaremba
Copy link
Collaborator

I thought the Codecov was fixed. It's still there and it's breaking the review experience.

@alessio
Copy link
Contributor

alessio commented Sep 17, 2020

I thought the Codecov was fixed. It's still there and it's breaking the review experience.

What made you think so? The conversation got stuck.

@alessio alessio merged commit 9cb27fb into master Sep 17, 2020
@alessio alessio deleted the atheesh/7067-staking-txns-tests branch September 17, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants