Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use *testing.T.TempDir() in tests #7346

Merged
merged 2 commits into from
Sep 18, 2020
Merged

use *testing.T.TempDir() in tests #7346

merged 2 commits into from
Sep 18, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Sep 18, 2020

Follow-up of #7128


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alessio alessio changed the title Alessio/testing t tempdir use *testing.T.TempDir() in tests Sep 18, 2020
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also double-checked that here's not other os.TempDir() in the codebase

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #7346 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7346      +/-   ##
==========================================
- Coverage   55.84%   55.84%   -0.01%     
==========================================
  Files         586      586              
  Lines       35967    35967              
==========================================
- Hits        20086    20084       -2     
- Misses      13913    13914       +1     
- Partials     1968     1969       +1     

@alessio alessio merged commit d6357e7 into master Sep 18, 2020
@alessio alessio deleted the alessio/testing-t-tempdir branch September 18, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants